Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in PSBT.sign_with #21

Closed
ghost opened this issue Aug 19, 2021 · 0 comments · Fixed by #22
Closed

Regression in PSBT.sign_with #21

ghost opened this issue Aug 19, 2021 · 0 comments · Fixed by #22

Comments

@ghost
Copy link

ghost commented Aug 19, 2021

I ran into a regression in the PSBT.sign_with function.

Before the taproot changes, if you relied on the default value for the sighash parameter and tried to sign an input where inp.sighhash_type = SIGHASH.ALL, this would work as expected and sign the input because the default value for sighash would also be SIGHASH.ALL.

Now, if an input with inp.sighash_type = SIGHASH.ALL is seen, it will be compared to sighash which will be SIGHASH.DEFAULT, resulting in a continue that skips signing the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants