You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ran into a regression in the PSBT.sign_with function.
Before the taproot changes, if you relied on the default value for the sighash parameter and tried to sign an input where inp.sighhash_type = SIGHASH.ALL, this would work as expected and sign the input because the default value for sighash would also be SIGHASH.ALL.
Now, if an input with inp.sighash_type = SIGHASH.ALL is seen, it will be compared to sighash which will be SIGHASH.DEFAULT, resulting in a continue that skips signing the input.
The text was updated successfully, but these errors were encountered:
I ran into a regression in the
PSBT.sign_with
function.Before the taproot changes, if you relied on the default value for the
sighash
parameter and tried to sign an input whereinp.sighhash_type = SIGHASH.ALL
, this would work as expected and sign the input because the default value forsighash
would also beSIGHASH.ALL
.Now, if an input with
inp.sighash_type = SIGHASH.ALL
is seen, it will be compared tosighash
which will beSIGHASH.DEFAULT
, resulting in acontinue
that skips signing the input.The text was updated successfully, but these errors were encountered: