Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for using the non-English BIP39 wordlists #11

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Jun 21, 2021

SeedSigner uses embit and I'd like to be able to use the Spanish language BIP39 wordlist in SeedSigner. Latin America has suddenly become the focus of the Bitcoin world and it would be a huge improvement for them to be able to use mnemonic phrases in their native language.

  • Doesn't add any extra bloat to the existing library.
  • Minimal code changes.
  • Leaves it up to the calling code to provide their own alternate wordlist if the default English list is not desired.
  • README updated and new test case.

@stepansnigirev
Copy link
Contributor

Looks great, thank you!

@stepansnigirev stepansnigirev merged commit 5b72733 into diybitcoinhardware:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants