Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add socks4 client support #16

Merged
merged 2 commits into from
May 7, 2022
Merged

add socks4 client support #16

merged 2 commits into from
May 7, 2022

Conversation

Yneth
Copy link
Contributor

@Yneth Yneth commented May 3, 2022

No description provided.

@Yneth Yneth changed the title add socks4 support add socks4 client support May 3, 2022
@dizda
Copy link
Owner

dizda commented May 4, 2022

Hi @Yneth

Could you please update the README.md accordingly
Also, could you add a rust feature and make sure this feature is disabled by default, as most of the people are expecting to use socks5 protocol according to the lib name.

Thank you for the PR.

@Yneth
Copy link
Contributor Author

Yneth commented May 4, 2022

@dizda sure

@Yneth Yneth marked this pull request as ready for review May 4, 2022 14:00
@Yneth
Copy link
Contributor Author

Yneth commented May 4, 2022

@dizda updated according to your comments

@dizda
Copy link
Owner

dizda commented May 7, 2022

Thank you @Yneth this looks great!

@dizda dizda merged commit ed3bf61 into dizda:master May 7, 2022
@dizda
Copy link
Owner

dizda commented May 7, 2022

Released v0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants