-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Paypal Support #1944
Comments
+1 I use Stripe Checkout and was able to hack a working test simply by adding the following to
I assume that for other workflows something would have to be added to payment_methods.py though? |
@HarryLafranc @colmmcmullan Yes the only change that is required is addition of |
Any updates for adding |
@agusmakmun it's live in 2.8.3 |
hello @jleclanche thank you for quick answer. We didn't see any https://github.com/dj-stripe/dj-stripe/blob/2.8.3/djstripe/models/payment_methods.py#L1021 only seeing the as |
Ah, I see what you mean. Okay yeah that will not be in 2.8. In 3.0 the class will change to always be up to date via a stripe_data field. |
@jleclanche I see. What we should do for this migration? Of course will have breaking changes right? |
Unfortunately, yes, it'll be quite a significant breaking change. |
Could you please give us the documentation how to smoothly migrating the dj-stripe from 2.x version to 3.x? Thank you btw 🙏 👍 |
@agusmakmun absolutely. Unfortunately the migration path doesn't exist at this time; I will do a write-up when we get to the release date. |
Changelog Link
https://stripe.com/docs/changelog#may-9,-2023
Describe the Change
Paypal was just introduced in Stripe, it would be nice to implement the bare minimum to make it work. I'm mainly getting errors in django admin because
_human_enum_values()
don't recognize "paypal" value. I don't know dj-stripe enough internally to know if others things must be reworked, but I will try to take a look at it!The text was updated successfully, but these errors were encountered: