Creating WebhooksEndpoint locally raises tolerance constraint failed error

[davemcphee]

Describe the bug
Attempting to create new WebhookEndpoint via django admin fails with djstripe.models.webhooks.WebhookEndpoint.DoesNotExist: WebhookEndpoint matching query does not exist.

above error is caused by failure to create local object:

sqlite: sqlite3.IntegrityError: NOT NULL constraint failed: djstripe_webhookendpoint.tolerance
mysql: MySQLdb.IntegrityError: (1048, "Column 'tolerance' cannot be null")

The WebhookEndpoint is successfully created in stripe, but not in the local DB.

To Reproduce
Steps to reproduce the behavior:

1. Fresh django installation with dj-stripe
2. python3 manage.py migrate && python3 manage.py runserver
3. Add an API key via Django admin
4. [optionally] run python3 manage.py djstripe_sync_models
5. Add a new WebhookEndpoint via django admin

Expected behavior
A new WebhookEndpoint is created in local django app

Environment

• dj-stripe version: 2.8.1
• stripe API version: "2022-11-15"
• Database: [any]
• Python version: 3.11.4
• Django version: 4.2.3

Can you reproduce the issue with the latest version of master?

Yes

It appears that the API does not return the tolerance key, so somewhere along the line this field is explicitly set to None, which eventually causes the error IntegrityError: NOT NULL constraint failed: djstripe_webhookendpoint.tolerance (as opposed to the default value being used as defined in the model).

This issue can be easily reproduced by modifying the webhook fixture (tests/fixtures/webhook_endpoint_fake0001.json) to remove the tolerance key, and running pytest.

I'm very new to dj-stripe, but issue can be resolved by adding a check to models.webhooks.WebhookEndpoint._attach_objects_hook:

    def _attach_objects_hook(
        self, cls, data, current_ids=None, api_key=djstripe_settings.STRIPE_SECRET_KEY
    ):
        ...
        self.djstripe_uuid = data.get("metadata", {}).get("djstripe_uuid")

        if not isinstance(data.get("tolerance", None), (int, float)):
            self.tolerance = djstripe_settings.WEBHOOK_TOLERANCE

If this is actually a bug, and the proposed fix looks good, I'd be happy to contribute a PR.

[zzart]

Had the same problem and this fixed it. +1

[PoDuck]

I am having the same issue. PabloCastellano's fix works. When might this get merged? As of now, it is impossible to create webhooks that work until this fix is integrated.

[KvyatkovskyAleksey]

In description to 2.8 version:
DJSTRIPE_WEBHOOK_TOLERANCE is deprecated in favour of the new UUID webhooks tolerance model field.
but in code presented:

if not isinstance(data.get("tolerance", None), (int, float)):
            self.tolerance = djstripe_settings.WEBHOOK_TOLERANCE

so, probably need to change to:
self.tolerance = stripe.Webhook.DEFAULT_TOLERANCE
because now i have error:
AttributeError: 'DjstripeSettings' object has no attribute 'WEBHOOK_TOLERANCE'

[jleclanche]

Thank you @KvyatkovskyAleksey.

[rob-gonz]

This is still an issue. I had to do something and modify the site-packages/djstripe module to get this to work just like OP. I appreciate it.

Version: djstripe=2.8.1