Added no-op AlterField migrations for Django 4.0 #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If these are noops then you should be able to modify old migrations, not create new ones. |
arnav13081994
force-pushed
the
generate_dj_3_10_migrations
branch
from
9ea888d
to
029400b
Compare
|
@jleclanche My bad.I updated the relevant files. |
jleclanche
reviewed
Feb 15, 2022
| @@ -1603,15 +1603,15 @@ class Migration(migrations.Migration): | |||
| help_text="The latest charge generated for this invoice, if any.", | |||
| null=True, | |||
| on_delete=django.db.models.deletion.CASCADE, | |||
| related_name="latest_invoice", | |||
| related_name="latest_%(class)s", | |||
There was a problem hiding this comment.
What is the first Django version to support this style of related name?
There was a problem hiding this comment.
3.2.0. Also none of the tests failed.
|
+1 |
jleclanche
pushed a commit
that referenced
this pull request
Jun 28, 2022
* Updated related_name of Invoice.charge to latest_%(class)s * Updated related_name of Invoice.customer to %(class)ss * Updated related_name of Invoice.subscription to %(class)ss * Updated related_name of UpcomingInvoice.subscription to %(class)ss * Updated related_name of UpcomingInvoice.customer to %(class)ss * Updated related_name of UpcomingInvoice.charge to latest_%(class)s * Updated related_name of Invoice.default_tax_rates to + * Updated related_name of Subscription.default_tax_rates to + * Updated related_name of SubscriptionItem.tax_rates to + * Updated related_name of InvoiceItem.tax_rates to + (cherry picked from commit e6d63f5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the following changes:
no-op AlterFieldmigrations form2mandfkfields as mentioned here. This was done because Django 4.0 generates migrations for ManyToManyField and ForeignKey fields.Checklist:
testsor confirm that my change doesn't require any updates.documentationor confirm that my change doesn't require any updates.migrationsor confirm that my change doesn't make changes to any model.Rationale
Fix #1592