Fix StripeDecimalCurrencyAmountField Defaults #1786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav13081994
force-pushed
the
fix_decimal_field
branch
from
8023134
to
713d975
Compare
arnav13081994
force-pushed
the
fix_decimal_field
branch
from
713d975
to
3e82256
Compare
jleclanche
force-pushed
the
master
branch
13 times, most recently
from
27c1106
to
f6483e8
Compare
arnav13081994
force-pushed
the
fix_decimal_field
branch
2 times, most recently
from
0fa9c31
to
7eb4a79
Compare
|
Only one migration and commit please |
Updated max_digits from 19 to 24 for unit_amount_decimal and amount_decimal model fields. This was done because the largest allowed value by Stripe is for the IDR (Indonesian Rupiah) which is 999,999,999,998.999,999,999,999 (24 digits, 12 decimals). In fact the Stripe console allows one to enter up to 14 decimals but automatically rounds off to 12 decimal places in its API. Updated StripeDecimalCurrencyAmountField defaults to 14 max_digits This was done because one can enter the max number in IDR (Indonesian Rupiah) currency of 999,999,999,998.99.
arnav13081994
force-pushed
the
fix_decimal_field
branch
from
7eb4a79
to
e8cb0af
Compare
|
@jleclanche Updated. Please review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the following changes:
max_digitsfrom 19 to 24 forunit_amount_decimalandamount_decimalmodel fields. This was done because the largest allowed value by Stripe is for theIDR (Indonesian Rupiah)which is999,999,999,998.999,999,999,999(24 digits, 12 decimals). In fact the Stripe console allows one to enter up to 14 decimals but automatically rounds off to 12 decimal places in its API.StripeDecimalCurrencyAmountFielddefaults to14 max_digits. This was done because one can enter the max number in IDR (Indonesian Rupiah) currency of999,999,999,998.99.Checklist:
testsor confirm that my change doesn't require any updates.documentationor confirm that my change doesn't require any updates.migrationsor confirm that my change doesn't make changes to any model.Rationale
Fix: #1762