-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass down kwargs to Invoice.pay()
#1968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done so that kwargs can be passed down to Invoice.pay()
This was done so that kwargs could be passed down to Invoice.pay().
@jleclanche Due to non-existent migrations pre-commit is failing. I have verified that all tests are passing and this change is completely backwards compatible. |
jleclanche
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Updated BaseInvoice.retry to accept kwargs This was done so that kwargs can be passed down to Invoice.pay() * Updated Customer.send_invoice method This was done so that kwargs could be passed down to Invoice.pay(). * Formatting fix * Updated docs
jleclanche
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Updated BaseInvoice.retry to accept kwargs This was done so that kwargs can be passed down to Invoice.pay() * Updated Customer.send_invoice method This was done so that kwargs could be passed down to Invoice.pay(). * Formatting fix * Updated docs
jleclanche
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Updated BaseInvoice.retry to accept kwargs This was done so that kwargs can be passed down to Invoice.pay() * Updated Customer.send_invoice method This was done so that kwargs could be passed down to Invoice.pay(). * Formatting fix * Updated docs (cherry picked from commit e9c55b5)
jleclanche
pushed a commit
that referenced
this pull request
Apr 25, 2024
* Updated BaseInvoice.retry to accept kwargs This was done so that kwargs can be passed down to Invoice.pay() * Updated Customer.send_invoice method This was done so that kwargs could be passed down to Invoice.pay(). * Formatting fix * Updated docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1959
One can now retry invoices with specific kwargs if they wish to do so.