Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Promotion Code model #2065

Merged
merged 3 commits into from
May 26, 2024
Merged

add Promotion Code model #2065

merged 3 commits into from
May 26, 2024

Conversation

abe-101
Copy link
Member

@abe-101 abe-101 commented May 22, 2024 •
edited
Loading

closes #1242

@abe-101
Copy link
Member Author

abe-101 commented May 22, 2024

@jleclanche Are there other things needed when adding new stripe objects?

@jleclanche
Copy link
Member

@abe-101 if there are event handlers they need to be registered.

From the API, I suggest exposing the code property at the very list. This is a property that would fetch into stripe_data like I showed you in the examples in the 3.0 branch.

@abe-101
Copy link
Member Author

abe-101 commented May 26, 2024

👍 Done

jleclanche
jleclanche requested changes May 26, 2024
View reviewed changes
djstripe/models/billing.py Outdated Show resolved Hide resolved
@jleclanche jleclanche merged commit 451d90b into dj-stripe:master May 26, 2024
2 of 7 checks passed
@abe-101 abe-101 mentioned this pull request Jun 4, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleclanche jleclanche jleclanche requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Promotion Codes
2 participants
@abe-101 @jleclanche