Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_changelist_filters is lost #121

Closed
manelclos opened this issue Aug 5, 2014 · 2 comments
Closed

_changelist_filters is lost #121

manelclos opened this issue Aug 5, 2014 · 2 comments
Milestone

Comments

@manelclos
Copy link

Hi,

I noticed _changelist_filters is not preserved in the "add" button, probably somewhere else too. This breaks both navigation and my app.

Thanks!

@xrmx
Copy link
Contributor

xrmx commented Aug 5, 2014

Indeed, for reference this is what django has in master, problem is that has been added in 1.6 django/django@c86a9b6 and we support django >= 1.4

templates/admin/change_form.html:        <a href="{% add_preserved_filters history_url %}" class="historylink">{% trans "History" %}</a>
templates/admin/change_list.html:              <a href="{% add_preserved_filters add_url is_popup to_field %}" class="addlink">
templates/admin/submit_line.html:    <p class="deletelink-box"><a href="{% add_preserved_filters delete_url %}" class="deletelink">{% trans "Delete" %}</a></p>

@manelclos
Copy link
Author

Yes, and it is a must-have feature. Is there a way to check for the existence of a tag?

@xrmx xrmx added this to the 1.8.0 milestone Aug 5, 2014
xrmx added a commit that referenced this issue Aug 22, 2014
Forward porting templates changes from here:
django/django@c86a9b6

Fix #121
@xrmx xrmx closed this as completed in 6003137 Aug 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants