Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button hover is broken in navbar-nav #156

Closed
brandoncazander opened this issue Nov 25, 2014 · 5 comments
Closed

Button hover is broken in navbar-nav #156

brandoncazander opened this issue Nov 25, 2014 · 5 comments

Comments

@brandoncazander
Copy link
Contributor

When hovering over the add button, you get a white bar instead of the usual bootstrap hover behaviour on btn-primary elements. The same buttons work fine elsewhere.

broken_bootstrap_django-admin

I'm seeing this on django-admin-bootstrapped==2.2.0 and Django==1.6.2, on both Chrome 39.0.2171.65 and Firefox 33.1.

@xrmx
Copy link
Contributor

xrmx commented Nov 25, 2014

Thanks for reporting the issue. I've definitely seen that too but thought it was some local issue. Am a bit puzzled about what the issue could be though since we are not doing anything fancy.

@xrmx xrmx closed this as completed in a813d1f Nov 25, 2014
@xrmx
Copy link
Contributor

xrmx commented Nov 25, 2014

Please double check it's working for you too. Would like to fix another bug (#129) before cutting a new release.

@brandoncazander
Copy link
Contributor Author

This works for me!

I did notice a warning on Context-specific usage in the bootstrap documentation that advises against using any standard button classes on elements inside of a .navbar-nav, so that explains why this was happening.

@brandoncazander
Copy link
Contributor Author

@xrmx I found one small issue with this - not that it's a big deal - but if you click the navbar buttons and open the link in a new tab or window, we still have this broken hover behaviour.

An easy fix would be to wrap any a tags with <span class="navbar-btn"></span>. Sorry I didn't catch this before!

xrmx added a commit that referenced this issue Nov 27, 2014
@xrmx
Copy link
Contributor

xrmx commented Nov 27, 2014

@brandoncazander thanks for noticing, should be fixed in master. Am looking at cleaning up django-filer templates and then i will cut another release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants