Allow to reload DN when using user-bind and DN-template #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisfreitag
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Nice work, the patch looks great. Happy to include it 🙏
Could you please edit the commit message to:
Allow to reload DN when using user-bind and DN-template
Useful when interacting with Microsoft AD, which may rely on User
Principal Name instead of the Distinguished Name as the attribute to
identify a user.
(feel free to rephrase)
|
|
||
| self.assertEqual(user.username, "charlie") | ||
| self.assertEqual(user.first_name, "Charlie") | ||
| self.assertEqual(user.last_name, "Cooper") |
There was a problem hiding this comment.
Suggested change
| self.assertEqual(user.last_name, "Cooper") | |
| self.assertEqual(user.last_name, "Cooper") | |
| self.assertEqual(user.ldap_user.dn, "cn=charlie_cooper,ou=people,o=test") |
Useful when interacting with Microsoft AD, which may rely on User Principal Name instead of the Distinguished Name as the attribute to identify a user.
|
Thank you @francoisfreitag, I have edited the commit message and also added the test line. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #346, this problem may arise when interacting with Microsoft AD in some configurations in which it is not possible to derive the distinguishedName DN from any part of userPrincipalName UPN (ie: when UPN is a substring of DN).
In example the following there is no way with simple templates to infer these DNs from given UPNs
Using a simple template there is no way to say which one could be with just the username
a.user, also is not guessable how the username is expanded in the DN due to name clash handling.