This repository has been archived by the owner on Nov 27, 2019. It is now read-only.
Adjust migrations for djangoCMS 3.3.0 and 3.3.1 compatibility #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,5 +4,6 @@ django-appconf | |||
| djangocms-helper>=0.9.1 | |||
| https://github.com/divio/django-filer/archive/develop.zip | |||
| djangocms-text-ckeditor | |||
| html5lib<0.99999999 | |||
There was a problem hiding this comment.
why it's here?
EDIT: I mean it doesn't seem to be related to the topic.
There was a problem hiding this comment.
It's very unfortunate but this app uses djangocms-text-ckeditor for testing which in turn installs the latest html5lib which is not compatible with anything.
So we have to limit html5lib to be less than the last release.
|
Code looks good 👍 but I don't really understand why you're explicitly defining "cmsplugin_ptr" field. Can you put short note here? |
|
Thanks @jqb. |
|
ok to merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
djangoCMS 3.3.1 introduced a change that by default sets related_name for
cmsplugin_ptrto%(app_label)s_%(class)s'. This means that any plugin model which did not explicitly set acmsplugin_ptrwould automatically get this change and prompt django to ask for migrations.To avoid incompatibilities between 3.3.0 and 3.3.1, we decided to explicitly define
cmsplugin_ptrto match the new format on plugins that need to support both versions.