Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0.0: Tests not in sdist tarball on pypi.org #69

Closed
dvzrv opened this issue Jan 23, 2022 · 4 comments · Fixed by #72
Closed

3.0.0: Tests not in sdist tarball on pypi.org #69

dvzrv opened this issue Jan 23, 2022 · 4 comments · Fixed by #72

Comments

@dvzrv
Copy link

dvzrv commented Jan 23, 2022

Hi! When attempting to package version 3.0.0 I noticed that the sdist tarball on pypi.org still does not contain the tests (see #52 (comment)).

Can they please be added to the sdist tarball? :)
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Jan 23, 2022
@dvzrv
upgpkg: python-django-classy-tags 3.0.0-1: Upgrade to 3.0.0.
99d089f 
Remove unneeded prepare().
Simplify quoting in file.
Add new upstream ticket to track missing tests in sdist tarball:
django-cms/django-classy-tags#69
Simplify installation in package() to adhere to Python package guidelines.
Remove unneeded tests dir removal (upstream fixed this).

git-svn-id: file:///srv/repos/svn-community/svn@1113609 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Jan 23, 2022
@dvzrv
upgpkg: python-django-classy-tags 3.0.0-1: Upgrade to 3.0.0.
3789ff7 
Remove unneeded prepare().
Simplify quoting in file.
Add new upstream ticket to track missing tests in sdist tarball:
django-cms/django-classy-tags#69
Simplify installation in package() to adhere to Python package guidelines.
Remove unneeded tests dir removal (upstream fixed this).

git-svn-id: file:///srv/repos/svn-community/svn@1113609 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@marksweb
Copy link
Sponsor Member

Hi @dvzrv! I hope I understand what you're after now.

Looking at the current release, the tarball only contains the python of the tests directory. But you need that to include everything so that you can actually run it.

Screenshot 2022-01-27 at 19 58 28

So I've updated the manifest to include the requirements and templates so that the tests should be able to function. Now the tarball includes all this;
Screenshot 2022-01-27 at 20 01 21

Is that right?

@dvzrv
Copy link
Author

dvzrv commented Jan 27, 2022

Is that right?

Thanks! That looks alright now! :)

@marksweb marksweb mentioned this issue Jan 28, 2022
Merged
@marksweb
Copy link
Sponsor Member

marksweb commented Feb 1, 2022

@dvzrv Please try 3.0.1 which I've just released. Hopefully that's got what you need now

@dvzrv
Copy link
Author

dvzrv commented Feb 3, 2022

Thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Inclusion of full tests package in tarball [#69] marksweb/django-classy-tags
2 participants
@dvzrv @marksweb