-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholder Inheritance in frontend editing #1303
Comments
Confirmed. |
It would be really great to have a fix in version 2.3 already. I try to use django-cms in a productive environment, and it is hard to sell a system to a customer when I have to tell him, that he can edit everything in frontend, except of the header. |
I agree on the importance of this issue: I escalated to core dev for further decisions. |
I'm not sure what the best approach here would be. Easiest: just disable the inheritance mechanism when in edit-mode. Not the most user-friendly approach, since the user is generally not aware that the content is inherited. Code impact: one line of code. This also reflects the current behavior in the admin. More complicated: show the inherited content in edit mode, but don't make it editable. Instead, add a helper text to tell the user to add new plugins to override the inherited content. Not sure how easy that would be. Best case in my opinion: copy the plugins in the placeholder when user enters edit mode, and delete them again if the user doesn't modify them. This way, the user doesn't even have to familiarize himself with the concept of "inheritance". But I have no clue in the first place how this could be solved and not result in a lot of unwanted copies. |
Last solution is too much error prone: I bet most of the users not editing the data will simply move away from the page, rather than cleaning exiting from edit mode. |
A further point in this discussion is the fact that frontend editing is a bit of a moving target right now. We should not invest to much time into a solution that might be outdated with the release of 2.4. |
In this perspective one-liners have their advantages :) |
@Schwankenson do you think that the proposed solution in #1356 would be OK for you? |
Yes, I think this is a good solution... @piquadrat: What do you mean with: |
in my base template, i have a header text. This text should be
editable in every level of my navigation, and it should inherit the
text of the levels above if there is no content.
So, here is my example:
In my base template, my placeholder is defined like:
So, this works without a problem. When there is no content, the
fallback is shown, and when I add some content for level 0 it is shown
in level 1.
And now, there is my problem: When I go to a level 1 navigation point
in my frontend and turn the edit mode on, then I edit the level 0
content for my placeholder. But of course, I want to edit the level 1
placeholder, to override my level 0 content with the level 1 content.
When I go to the admin panel, and edit the level 1 content, everything
works fine. But I want to do it in the frontend.
The text was updated successfully, but these errors were encountered: