Update install.rst #7468
Closed
Update install.rst #7468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated steps for installing and configuring sekizai
marksweb
reviewed
Jan 4, 2023
| @@ -210,16 +210,15 @@ After each of the steps below run ``cms check`` to verify that you have resolved | |||
| Sekizai | |||
| ======= | |||
|
|
|||
| `Django Sekizai <https://github.com/ojii/django-sekizai>`_ is required by the CMS for static files management. You need | |||
| to have:: | |||
| `Django Sekizai <https://github.com/ojii/django-sekizai>`_ is required by the CMS for static files management. For that, you need to install the package, add it to installed apps and to your context_processors by following steps:: | |||
There was a problem hiding this comment.
Sekizai is one of the requirements of the cms so we shouldn't need to specify installing it separately.
See here: https://github.com/django-cms/django-cms/blob/develop/setup.py#L13
There was a problem hiding this comment.
Yes, I can remove the install line. I think for some reasons, it wasn’t installed for me and I had to manually install it and packaging library which was why I added it in the docs
|
Yes you are correct about not needing to explicitly install the Selizai dependency. I think the doc was not formatted for clear interpretation at the configuration of sekizai. I could remove the PR or just remove the installation script for the Sekizai library, your call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated steps for installing and configuring sekizai
Description
Related resources
Checklist
develop