Allow latest unidecode version #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves dependency issue in other projects where Unidecode >= 1.1 is needed.
Codecov Report
@@ Coverage Diff @@
## master #1171 +/- ##
=======================================
Coverage 70.98% 70.98%
=======================================
Files 63 63
Lines 3102 3102
Branches 444 444
=======================================
Hits 2202 2202
Misses 747 747
Partials 153 153Continue to review full report at Codecov.
|
jrief
reviewed
Dec 18, 2019
jrief
approved these changes
Dec 19, 2019
FinalAngel
added a commit
that referenced
this pull request
Sep 3, 2020
* Store mimetype of uploaded file in database * Fix a few CI errors * set default mime_type to application/octet-stream * Server.serve() now accepts a filer.File object * Fix: JPG testimage shall be uploaded with Content-Type image/jpeg * fix flake8 complaints * Use NotImplementedError * fix flake8 complaints * describe changes * use master branch instead of develop * add additional tests to support MIME type * check that content-type is stored by django-filer * Allow latest unidecode version (#1171) * Allow latest unidecode version Resolves dependency issue in other projects where Unidecode >= 1.1 is needed. * Fix annotation by @yakky on PR #1152 * use url instead of path to guess mime-type * Use property ‘download’ to reuse original filename (#1169) * Use property ‘download’ to reuse original filename * add feature to changelog Co-authored-by: Angelo Dini <angelo.dini@divio.ch> Co-authored-by: Ashish Patil <ashishnitinpatil@gmail.com>
FinalAngel
added a commit
that referenced
this pull request
Sep 3, 2020
* Store mimetype of uploaded file in database (#1152) * Store mimetype of uploaded file in database * Fix a few CI errors * set default mime_type to application/octet-stream * Server.serve() now accepts a filer.File object * Fix: JPG testimage shall be uploaded with Content-Type image/jpeg * fix flake8 complaints * Use NotImplementedError * fix flake8 complaints * describe changes * use master branch instead of develop * add additional tests to support MIME type * check that content-type is stored by django-filer * Allow latest unidecode version (#1171) * Allow latest unidecode version Resolves dependency issue in other projects where Unidecode >= 1.1 is needed. * Fix annotation by @yakky on PR #1152 * use url instead of path to guess mime-type * Use property ‘download’ to reuse original filename (#1169) * Use property ‘download’ to reuse original filename * add feature to changelog Co-authored-by: Angelo Dini <angelo.dini@divio.ch> Co-authored-by: Ashish Patil <ashishnitinpatil@gmail.com> * Edit documentation * fix flake * adapt changelog Co-authored-by: Jacob Rief <jacob.rief@gmail.com> Co-authored-by: Ashish Patil <ashishnitinpatil@gmail.com> Co-authored-by: Iacopo Spalletti <i.spalletti@nephila.digital>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dependency issue in other projects where Unidecode >= 1.1 is needed.