feat: Accept new STORAGES setting, introduced in Django 4.2
#1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1458.
Django 4.2 introduced the new
STORAGESsetting. The historicDEFAULT_FILE_STORAGEsetting is deprecated and will be removed in Django 5.1.This PR makes use of the
STORAGESsetting if present, otherwise falls back toDEFAULT_FILE_STORAGEfor compatibility with older Django versions.https://github.com/fsbraun/django-filer/blob/984a45b71654dc5e4b349b076a726aaa96988d86/filer/settings.py#L62-L65
Also, this PR includes the changes from
pyupgradefor Python 3.8+Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.