Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace render with TemplateResponse in admin views #1473

Merged
merged 1 commit into from
May 20, 2024
Merged

feat: Replace render with TemplateResponse in admin views #1473

merged 1 commit into from
May 20, 2024

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented May 19, 2024

Description

As requested in #1448 and common practice in the Django admin, this PR makes the admin views return a TemplateResponse.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from a team May 19, 2024 16:29
@fsbraun fsbraun merged commit db416e6 into django-cms:master May 20, 2024
42 checks passed
@fsbraun fsbraun deleted the feat/template-response branch May 20, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fsbraun @marksweb