Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger change event on hidden input when image id changes #501

Merged
merged 1 commit into from
Mar 11, 2015

Conversation

astagi
Copy link
Contributor

@astagi astagi commented Feb 28, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.76% when pulling 1fef5b2 on astagi:feature/idchange into 24eb40b on stefanfoulis:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.76% when pulling 1fef5b2 on astagi:feature/idchange into 24eb40b on stefanfoulis:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.76% when pulling 1fef5b2 on astagi:feature/idchange into 24eb40b on stefanfoulis:develop.

@yakky
Copy link
Member

yakky commented Mar 1, 2015

LGTM
@stefanfoulis you ok with this?

document.getElementById(name).value = chosenId;
document.getElementById(img_name).src = chosenThumbnailUrl;
document.getElementById(txt_name).innerHTML = chosenDescriptionTxt;
document.getElementById(clear_name).style.display = 'inline';
if (old_id != chosenId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current code style requires to always use brackets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! sorry :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.76% when pulling dbc794e on astagi:feature/idchange into 025e55b on stefanfoulis:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.76% when pulling dbc794e on astagi:feature/idchange into 025e55b on stefanfoulis:develop.

yakky added a commit that referenced this pull request Mar 11, 2015
Trigger change event on hidden input when image id changes
@yakky yakky merged commit 369e948 into django-cms:develop Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants