#954 avoid orphaned files when using admin > advanced > replace file

[SachaMPS]

This should be a workaround for:
#954

[benzkji]

not a real workaround, looks ok?! slightly better exception handling could be done, but then that's it - I once read one should not just except:, but always provide what you expect to except...

+1 for merging this and wasting less server space ;-)

[yakky]

Thanks for contributing this, definitely much needed. I only added a minor remark, could you address it?

[yakky]

It's better to explicitly handle the expected exceptions

[yakky]

@SachaMPS Thanks for contributing this,, could you rebase on top of current develop?
Sorry it took so long to handle this

[benzkji]

how about a merge...1.4 is out :-)

[jrief]

@benzkji I fully agree with @yakky on #958 (comment)

[benzkji]

sure!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[benzkji]

is this issue resolved? anyone?

[merwok]

No, this PR was not merged (author did not reply to review) and the ticket is still open.

[benzkji]

someone would need to handle the exception, and off we go, right?

[marksweb]

What are the possible exceptions here. Obviously there's the DoesNotExist from the get(), but is there something else?

[benzkji]

if this.file is none (not the usual case, but could be...), this.file.delete() would throw a "None has no method 'delete()'". Rather edge case. Dont see others...

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This will now be closed due to inactivity, but feel free to reopen it.

[benzkji]

This is important, isn't it?

[benzkji]

@jrief or was this alreaedy merge before? It's an easy picking...