-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt django-sekizai for Django 1.11 #71
Comments
okay, so where is the problem?
why? what are the problems that require me to do a release? If there are indeed problems, please read this first https://gist.github.com/ojii/d428e7470dc62706f8ee89681bc95208 |
I don't have a concrete case now. I guess just the documentation should rather be updated stating that Django 1.11 is supported. |
found some bugs with 1.11 and will try to make a release over the holidays later this week. |
Any news on this? :-) |
I did some work on this but it is incredibly low on my list of priorities, so no real news for now. |
Hi Jonas, anything I can do to help out here? Kinda bummed-out my 1.11 project breaks with your beloved sekizai tags! |
@mkoistinen since I'm no longer using this project, I'm not too interested in continuing to maintain it. If someone (you?) wants to take over, I'll move the GH project and add them to the pypi project. |
divio presumably care about sekizai since django-cms relies on it; maybe they would like to take it over (@vxsx @evildmp) The fun bit about Django 1.11 is that it explicitly checks that the contexts you pass into the templating system are not, er, Contexts - they must be dictionaries. Going by the Django docs, the value for the 'context' argument was never supposed to be a Context, it was always supposed to be a dictionary. This presumably means that people using the SekizaiContext are going to be out of luck, but I'm guessing most people don't do that, and there's nothing you can do about it anyway. I have made a pull request #75 which updates the tests so that they now pass on all supported versions of Python and Django up to 3.6 and 1.11. |
Should this be closed? |
Django sekizai seems to also work on Django 1.11, but I haven't tested all possible cases.
Are there plans to release a new version of django-sekizai anytime soon?
The text was updated successfully, but these errors were encountered: