Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sekizai tests work on Django 1.11 #75

Closed
wants to merge 9 commits into from
Closed

Make sekizai tests work on Django 1.11 #75

wants to merge 9 commits into from

Conversation

jribbens
Copy link

The main issue is that Django 1.11 no longer allows Contexts to be used as, er, contexts.

It also required dealing with pep8's rename to pycodestyle.

@jribbens jribbens mentioned this pull request Nov 14, 2017
Closed
@mjrulesamrat
Copy link

Great PR. Le's merge it.

ojii
ojii reviewed Jan 21, 2018
View reviewed changes
sekizai/tests.py Outdated
ctx = ctx or {}
return render_to_string(tpl, ctxclass(ctx))
ctx = dict(ctx) if ctx else {}
if ctxclass == SekizaiContext:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use issubclass(ctxclass, SekizaiContext)

@jribbens
Copy link
Author

Ok used issubclass as requested. The 'circleci' tests are failing because circleci is using Python 2.7 and https://github.com/ojii/django-classy-tags is requiring just Django>1.3 which is installing Django 2 which doesn't work under Python 2. So I don't think this test failure should prevent you merging the PR.

@ojii
Copy link
Collaborator

ojii commented Jan 22, 2018

Ok used issubclass as requested. The 'circleci' tests are failing because circleci is using Python 2.7 and https://github.com/ojii/django-classy-tags is requiring just Django>1.3 which is installing Django 2 which doesn't work under Python 2. So I don't think this test failure should prevent you merging the PR.

Thank you for your pull request. Unfortunately, right now I'm in the process of transferring this repository to the divio organization (developers of django CMS) on Github, so it might take a little while for this to get accepted. Thank you for your patience.

@timgraham
Copy link
Contributor

I submitted #79 to drop support for Django < 1.11 and add support for Django 1.11+. Maybe you could repurpose this branch to make the pycodestyle changes?

@DmytroLitvinov DmytroLitvinov mentioned this pull request Mar 5, 2019
Merged
@FinalAngel FinalAngel closed this Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojii ojii ojii left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jribbens @mjrulesamrat @ojii @timgraham @FinalAngel