Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Release 3.3 #508

Merged
merged 7 commits into from
Jan 27, 2024
Merged

feat: Release 3.3 #508

merged 7 commits into from
Jan 27, 2024

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Jan 13, 2024

The PR adds back flex styling for multicolumn field sets to increase compatibility with Django 4.2+ admin styles.

Fixes a margin issue with checkbox helptexts

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7dcfba) 100.00% compared to head (07078c4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

More: Flexbox-misalignments
@fsbraun fsbraun marked this pull request as ready for review January 24, 2024 10:26
@fsbraun fsbraun requested a review from a team January 24, 2024 10:26
@fsbraun fsbraun changed the title feat: Release 3.2.8 feat: Release 3.3 Jan 24, 2024
@DmytroLitvinov
Copy link

Hi @fsbraun ,
Not sure, but may I ask if that issue is fixed in that PR?
image

@fsbraun
Copy link
Sponsor Member Author

fsbraun commented Jan 25, 2024

Should. But I'd appreciate if you could check. Can you install from my patch and test?

pip install git+https://github.com/fsbraun/djangocms-admin-style@chore/bump-to-3.2.8

@DmytroLitvinov
Copy link

@fsbraun , no branch like chore/bump-to-3.2.8
image

@DmytroLitvinov
Copy link

Should be from django-cms organization - pip install git+https://github.com/django-cms/djangocms-admin-style@chore/bump-to-3.2.8

@DmytroLitvinov
Copy link

Seems like fixed.

image

@fsbraun fsbraun merged commit a74035b into master Jan 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants