Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved rules #518

Merged
merged 8 commits into from
Feb 20, 2024
Merged

Solved rules #518

merged 8 commits into from
Feb 20, 2024

Conversation

raffaellasuardini
Copy link
Contributor

Solved rules:

  • I001 (import block unsorted)
  • E501 (line too long)
  • C408 (unnecessary dict call)

Updated pyproject.toml by removing extend-ignore list

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfc0747) 100.00% compared to head (4df2260) 100.00%.
Report is 1 commits behind head on master.

❗ Current head 4df2260 differs from pull request most recent head 547c8e4. Consider uploading reports for the commit 547c8e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marksweb
Copy link
Member

Would be good to add .po files to the ignored list. Though the changes to them here are fine

@raffaellasuardini
Copy link
Contributor Author

Ok I'm going to update the pyproject

@marksweb marksweb merged commit 7b7e5e5 into django-cms:master Feb 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants