Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add localization and transifex support #151

Merged
merged 18 commits into from
Jan 13, 2023

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Jan 10, 2023

This PR adds localization (starting with partial German translation) and transifex support.

@fsbraun fsbraun requested a review from marksweb January 10, 2023 21:46
Copy link
Sponsor Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fsbraun 👍

I've got some changes in #150 which fix the tests, but I wasn't able to get tests for django 2.2 working - they didn't like the use of the translate template tag but I wasn't sure where the HTML was coming from. So felt it might be worth just dropping support for 2.2 given that it's EOL.

@fsbraun
Copy link
Sponsor Member Author

fsbraun commented Jan 11, 2023

@marksweb Before merging fixed tests (and dropping Django 2.2 support) we should branch off support/4.0.x as we did with djangocms-verisoning I recon.

@fsbraun fsbraun merged commit d7ab8a9 into django-cms:master Jan 13, 2023
@fsbraun fsbraun deleted the feat/transifex branch January 13, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants