Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow same name for category in different languages #189

Merged
merged 3 commits into from
Jul 26, 2023
Merged

allow same name for category in different languages #189

merged 3 commits into from
Jul 26, 2023

Conversation

vasekch
Copy link
Contributor

@vasekch vasekch commented Jul 26, 2023

Dropping unique on Category name and adding unique together for name and language.

This will allow to use the same name for a Alias Category across different languages.

fsbraun
fsbraun approved these changes Jul 26, 2023
View reviewed changes
Copy link
Sponsor Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great PR. Let's get this merged!

@fsbraun
Copy link
Sponsor Member

fsbraun commented Jul 26, 2023

@vasekch While at it, can you add the migration from #175 to the migration (also 0003) here?

@vasekch
Copy link
Contributor Author

vasekch commented Jul 26, 2023

@fsbraun thanks for processing this. I realized that there is a forgotten migration in #186 so I've added it. It's a bit clashing.
I first include #175 in here and then leave it up to you which you'll merge first then I'll update the second one (migrations deps).

This was referenced Jul 26, 2023
Closed
Merged
@vasekch
Copy link
Contributor Author

vasekch commented Jul 26, 2023

... then leave it up to you which you'll merge first then I'll update the second one (migrations deps).

ok, this should go first and #186 is ready to go right after that

@fsbraun fsbraun merged commit d88a28f into django-cms:master Jul 26, 2023
10 checks passed
@vasekch vasekch deleted the fix/category-name-unique-per-lang branch July 26, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vasekch @fsbraun