Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Django 4.2 support #32

Merged
merged 11 commits into from
Jun 28, 2023
Merged

feat: Django 4.2 support #32

merged 11 commits into from
Jun 28, 2023

Conversation

marksweb
Copy link
Sponsor Member

Description

This overhauls the app a little, while adding the migration which django 4.2 wants to create.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

Copy link
Sponsor Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marksweb
Copy link
Sponsor Member Author

@fsbraun Need to just work out this coverage issue

@marksweb marksweb merged commit 43782a5 into django-cms:master Jun 28, 2023
6 checks passed
@marksweb marksweb deleted the overhaul branch June 28, 2023 08:45
@marksweb marksweb self-assigned this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants