Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#101, use proper iconset prefix in ckeditor preview #103

Merged
merged 3 commits into from
Aug 27, 2020

Conversation

sq9mev
Copy link
Contributor

@sq9mev sq9mev commented Jan 30, 2020

No description provided.

@FinalAngel
Copy link
Member

@sq9mev this appears to change only the compiled file, could you make the change in the source file?

@sq9mev
Copy link
Contributor Author

sq9mev commented Jan 31, 2020

@FinalAngel well, now i see it's build with webpack… unfortunelly i'no not familiar with it… actually i could just modify blindly the source as the change is small, but let me do that right way (using wepback), patch will be provided soon.

@codecov-io
Copy link

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #103   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          68     68           
  Lines        1286   1286           
  Branches       87     87           
=====================================
  Hits         1286   1286

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b93b04...ceee0d7. Read the comment docs.

@FinalAngel
Copy link
Member

thank you very much, I'll have a look at it in the next days :)

Copy link
Contributor

@corentinbettiol corentinbettiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2020

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #103    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           68        68            
  Lines         1286      1465   +179     
  Branches        87       123    +36     
==========================================
+ Hits          1286      1465   +179     
Impacted Files Coverage Δ
...gocms_bootstrap4/contrib/bootstrap4_card/models.py 100.00% <0.00%> (ø)
...gocms_bootstrap4/contrib/bootstrap4_grid/models.py 100.00% <0.00%> (ø)
...gocms_bootstrap4/contrib/bootstrap4_link/models.py 100.00% <0.00%> (ø)
...gocms_bootstrap4/contrib/bootstrap4_tabs/models.py 100.00% <0.00%> (ø)
...ocms_bootstrap4/contrib/bootstrap4_badge/models.py 100.00% <0.00%> (ø)
...cms_bootstrap4/contrib/bootstrap4_alerts/models.py 100.00% <0.00%> (ø)
...ms_bootstrap4/contrib/bootstrap4_content/models.py 100.00% <0.00%> (ø)
...ms_bootstrap4/contrib/bootstrap4_picture/models.py 100.00% <0.00%> (ø)
...s_bootstrap4/contrib/bootstrap4_carousel/models.py 100.00% <0.00%> (ø)
...s_bootstrap4/contrib/bootstrap4_collapse/models.py 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8300c3...ac2c8ad. Read the comment docs.

@FinalAngel
Copy link
Member

@sq9mev just got to it and the commit fixes the problem. Thank you!

@FinalAngel FinalAngel merged commit 53bdba8 into django-cms:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants