-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#101, use proper iconset prefix in ckeditor preview #103
Conversation
@sq9mev this appears to change only the compiled file, could you make the change in the source file? |
@FinalAngel well, now i see it's build with webpack… unfortunelly i'no not familiar with it… actually i could just modify blindly the source as the change is small, but let me do that right way (using wepback), patch will be provided soon. |
…ed source and compiled file)
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 68 68
Lines 1286 1286
Branches 87 87
=====================================
Hits 1286 1286 Continue to review full report at Codecov.
|
thank you very much, I'll have a look at it in the next days :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 68 68
Lines 1286 1465 +179
Branches 87 123 +36
==========================================
+ Hits 1286 1465 +179
Continue to review full report at Codecov.
|
@sq9mev just got to it and the commit fixes the problem. Thank you! |
No description provided.