Quick: Avoid Coupling Bootstrap and Generic Link

[wesleyboar]

Goal

Do not couple Bootstrap Link plugin to Generic link plugin.

Changes

1. In Link plugin, mimic how Picture plugin creates fieldsets from corresponding generic plugin.

Testing

Manual testing:

1. Have a CMS that installs Bootstrap4 Link and Picture plugin.
2. Edit code to support Bootstrap and Generic Link and Picture plugin.
   • Install plugin to re-enable Generic Link plugin:
     https://github.com/TACC/Core-CMS/blob/884194e/taccsite_cms/settings.py#L241-L242
   • Add plugin to re-enable Generic Link plugin:
     https://github.com/TACC/Core-CMS/blob/884194e/taccsite_cms/contrib/bootstrap4_djangocms_link/cms_plugins.py
3. Remove extra code for supporting Link plugins:
   • Remove lines https://github.com/TACC/Core-CMS/blob/884194e/taccsite_cms/contrib/bootstrap4_djangocms_link/cms_plugins.py#L7.
   • Remove lines https://github.com/TACC/Core-CMS/blob/884194e/taccsite_cms/contrib/bootstrap4_djangocms_link/cms_plugins.py#L14-L28.
4. Add and save these plugins:
   • "Generic" > "Link"
   • "Bootstrap4" > "Link"

Background

Supporting (A) Generic "Link" plugin and Bootstrap "Link / Button" plugin takes more code than (B) Generic "Image" plugin and Bootstrap "Picture / Image" plugin, because Bootstrap Link plugin points to Generic Link plugin fieldsets, instead of cloning them (like Bootstrap Picture plugin).

1. If a user wants to use Generic "Link" plugin and Bootstrap "Link / Button" plugin, they cannot immediately do so.
   • Link doesn't appear in the plugins list djangocms-link#163
   • LinkPlugin is silently unregistered by bootstrap4_link djangocms-link#167
2. A user can do so, by following instructions like these:
   • Link doesn't appear in the plugins list djangocms-link#163 (comment)
   • Quick: Support Non-Bootstrap Link & Picture Plugins TACC/Core-CMS#278
3. When a user wants to use Generic "Image" plugin and Bootstrap "Picture / Image" plugin, the solution is simpler:
   • https://github.com/TACC/Core-CMS/blob/884194e/taccsite_cms/contrib/bootstrap4_djangocms_picture/cms_plugins.py#L5-L11
4. The solution for Generic "Link" plugin and Bootstrap "Link / Button" plugin, the solution is not as simple:
   • https://github.com/TACC/Core-CMS/blob/884194e/taccsite_cms/contrib/bootstrap4_djangocms_link/cms_plugins.py#L14-L28

[marksweb]

I'm a fan of consistency, so thanks for the contribution 👍

[crydotsnake]

Can i merge it ? @marksweb

[marksweb]

Can i merge it ? @marksweb

@crydotsnake Sure.

Do you see this squash and merge option? This is what I was talking about on your docs PR. This option creates 1 commit for the PR in the target branch.

[crydotsnake]

Can i merge it ? @marksweb

@crydotsnake Sure.

Do you see this squash and merge option? This is what I was talking about on your docs PR. This option creates 1 commit for the PR in the target branch.

Yes, I was blind at the first moment and saw it only afterwards 🙈.

[crydotsnake]

@marksweb Oops... I think some tests failed. But that was shown to me only after the merge.

https://github.com/django-cms/djangocms-bootstrap4/runs/4082975004?check_suite_focus=true

[marksweb]

@marksweb Oops... I think some tests failed. But that was shown to me only after the merge.

https://github.com/django-cms/djangocms-bootstrap4/runs/4082975004?check_suite_focus=true

Ah I'm on my phone so can't see checks & actions in the app.