Introduced pre-commit functionality #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CMS 3.9 to test suite
* B007 Loop control variable 'x' not used within the loop body. If this is intended, start the name with an underscore. * N400: Found backslash that is used for line breaking * C408 Unnecessary tuple call - rewrite as a literal.
… installation guide
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 1211 1211
Branches 65 65
=========================================
Hits 1211 1211
Continue to review full report at Codecov.
|
|
Alongside these pre-commit setups, it'd be ideal to also include pre-commit CI to keep the versions of hooks updated; (This needs to be installed to the repos as we merge these hooks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First thing I've done here is to bring tox and the setup classifiers inline with the python versions we're actually testing against; Python 3.7, 3.8, 3.9.
Then I've added testing against CMS 3.9
The main feature here though is the addition of pre-commit hooks. The github actions are currently running flake8 and isort, so it makes sense to have these run as pre-commit hooks. I've also introduced
pyupgradewhich can be set to a target version (3.7 given that's the base version for testing against) and it will upgrade python code to suit if there are things that can be done better. A lot of the changes here come from pyupgrade & are automated by that tool.