Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Bootstrap4Picture to reflect djangocms_picture.AbstractPicture changes regarding Responsive Images #65

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Adapt Bootstrap4Picture to reflect djangocms_picture.AbstractPicture changes regarding Responsive Images #65

merged 2 commits into from
Oct 19, 2018

Conversation

filwaitman
Copy link
Contributor

kinkerl
kinkerl approved these changes Oct 9, 2018
View reviewed changes
Copy link

@kinkerl kinkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that enough? doesn't this need some rendering or some admin changes as well? if not, ok!

@filwaitman
Copy link
Contributor Author

@kinkerl not needed since we're calling super inside Bootstrap4PicturePlugin.render(). In fact I tried locally and it looks good. =]

Thanks for the review!

@filwaitman filwaitman merged commit 1960bc0 into master Oct 19, 2018
@filwaitman filwaitman deleted the feature/responsive-images branch October 19, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinkerl kinkerl kinkerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filwaitman @kinkerl