Improve test coverage #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=========================================
+ Coverage 67.66% 100% +32.33%
=========================================
Files 69 68 -1
Lines 1364 1286 -78
Branches 96 87 -9
=========================================
+ Hits 923 1286 +363
+ Misses 433 0 -433
+ Partials 8 0 -8
Continue to review full report at Codecov.
|
koniiiik
reviewed
Sep 6, 2019
| self.assertEqual(response.status_code, 200) | ||
| self.assertContains(response, '<div class="row">') | ||
|
|
||
| # add row with values |
There was a problem hiding this comment.
You meant column, right? (Same below.)
koniiiik
reviewed
Sep 6, 2019
koniiiik
approved these changes
Sep 6, 2019
* added tests for the other modules * adapted tests for python 2 * remove them * adapt change from comment * pushed comment changes * remove whitespace * revert changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django-filerto 1.5.0This needs to be merged first:
#96