Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial Django 2.0 support #30

Closed
wants to merge 1 commit into from
Closed

initial Django 2.0 support #30

wants to merge 1 commit into from

Conversation

russmo
Copy link

@russmo russmo commented Feb 15, 2018

Squashing some incompatibilities between Django 1.11 and 2.0.

django-cms is not Django 2.0 ready yet, but I'm trying to get various plugins and dependencies compatible to make it easier for the whole ecosystem to work on 2.0.x eventually.

@codecov-io
Copy link

codecov-io commented Feb 16, 2018

Codecov Report

Merging #30 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   81.98%   81.87%   -0.12%     
==========================================
  Files          13       12       -1     
  Lines         161      160       -1     
  Branches       11       11              
==========================================
- Hits          132      131       -1     
  Misses         28       28              
  Partials        1        1
Impacted Files Coverage Δ
djangocms_file/migrations/0008_add_folder.py 100% <ø> (ø) ⬆️
djangocms_file/models.py 65.57% <ø> (ø) ⬆️
djangocms_file/migrations/0001_initial.py 100% <ø> (ø) ⬆️
djangocms_file/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17005a9...8780823. Read the comment docs.

@filwaitman
Copy link

@russmo thanks for the PR!
I'm closing this on in favor of #34 - as the latter has a more complete approach, ok?

@filwaitman filwaitman closed this Oct 12, 2018
@russmo
Copy link
Author

russmo commented Oct 12, 2018

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants