Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move autocomplete view for links to admin #211

Merged
merged 50 commits into from
Apr 24, 2024

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Apr 24, 2024

This PR removes the need for registering its own autocomplete view by moving the autocomplete view to the Link plugin itself.

Note: The link plugin handles the autocomplete view also for other plugins using the LinkPluginMixin.

Expected to fix #209

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 86.39%. Comparing base (f11feee) to head (d1392f3).
Report is 18 commits behind head on master.

Files Patch % Lines
djangocms_frontend/contrib/grid/forms.py 0.00% 2 Missing ⚠️
djangocms_frontend/contrib/link/forms.py 81.81% 2 Missing ⚠️
djangocms_frontend/templatetags/frontend.py 0.00% 2 Missing ⚠️
djangocms_frontend/common/title.py 0.00% 1 Missing ⚠️
djangocms_frontend/contrib/carousel/models.py 0.00% 0 Missing and 1 partial ⚠️
...ms_frontend/contrib/icon/templatetags/icon_tags.py 0.00% 1 Missing ⚠️
djangocms_frontend/contrib/link/cms_plugins.py 85.71% 0 Missing and 1 partial ⚠️
djangocms_frontend/contrib/link/helpers.py 0.00% 1 Missing ⚠️
djangocms_frontend/contrib/link/models.py 0.00% 0 Missing and 1 partial ⚠️
...angocms_frontend/contrib/navigation/cms_plugins.py 83.33% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   86.93%   86.39%   -0.54%     
==========================================
  Files         120      119       -1     
  Lines        3107     3109       +2     
  Branches      330      332       +2     
==========================================
- Hits         2701     2686      -15     
- Misses        304      320      +16     
- Partials      102      103       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsbraun fsbraun merged commit fbed89f into django-cms:master Apr 24, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link/Button admin page failed to show the list of page to select an internal link
1 participant