Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dark mode support for iconpicker #46

Merged
merged 9 commits into from
Sep 9, 2022
Merged

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Sep 9, 2022

Description

This PR adds dark mode support (with django CMS 3.11+) for the icon picker. Also, it runs tests against Django 4.0.

It adds a .nvmrc for version 8 to be able to run gulp.
Finally, it prepares to be tested against django CMS 4.

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #46 (1a6d935) into master (20efce5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         9    +1     
  Lines          123       128    +5     
  Branches        20        21    +1     
=========================================
+ Hits           123       128    +5     
Impacted Files Coverage Δ
...s_icon/migrations/0003_alter_icon_cmsplugin_ptr.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fsbraun fsbraun merged commit 2d05705 into django-cms:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants