Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inline editing workaround for toolbar bug in django CMS <= 3.9 #619

Merged
merged 4 commits into from Jun 22, 2022

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Jun 22, 2022

This implements a workaround for #620 : Automatic reload of whole page. The garbled tool bar is due to a bug fixed in django CMS 3.10: django-cms/django-cms#7114

@fsbraun fsbraun changed the title fix: Inline editing Workaround for toolbar bug in django CMS <= 3.9 fix: Inline editing workaround for toolbar bug in django CMS <= 3.9 Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #619 (6878cf4) into master (606fc86) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #619   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files          20       20           
  Lines         905      905           
  Branches      128      128           
=======================================
  Hits          678      678           
  Misses        199      199           
  Partials       28       28           
Impacted Files Coverage Δ
djangocms_text_ckeditor/widgets.py 80.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606fc86...6878cf4. Read the comment docs.

@fsbraun fsbraun requested a review from marksweb June 22, 2022 07:58
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fsbraun nice work 🙏

@marksweb
Copy link
Member

Oh, changelog entry? @fsbraun

@fsbraun
Copy link
Sponsor Member Author

fsbraun commented Jun 22, 2022

Yeah, you only notice other people's change log entry missing. I'll add it. 👍

@fsbraun fsbraun merged commit 4a22b8b into django-cms:master Jun 22, 2022
@fsbraun fsbraun deleted the fix/workaround-toolbar-bug branch June 22, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants