Enable copy plugins - remove translations is commented out #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change_language_menu is taken from the most recent version in django-cms. In essence we don't need to monkeypatch this, right now we still need this monkeypatch because the work to overwrite the delete view in pagecontent admin is not yet done. Once that work is done this monkeypatch is redundant.
These tests are now out of date. Since the functionality is one to one with django-cms (except for the removal-urls) I have pre-emptively removed the change_language_menu tests.
3 tasks
|
The toolbar is no longer monkey patched to use the toolbar system correctly. |
|
@Aiky30 Glad you're slowly working around all these PRs. I do hope they came to use in the end. |
|
@jonathan-s I've been a little reluctant to change much in versioning right now due to the fact the it's being used in some big sites now. I'm hoping to pick up the work that you did for bringing the comparison improvements to life again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change_language_menu is taken from the most recent version
in django-cms. In essence we don't need to monkeypatch this,
right now we still need this monkeypatch because the work to
overwrite the delete view in pagecontent admin is not yet done.
Depends on: