Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Compat with cms page content extension changes #291

Merged
merged 9 commits into from
Nov 30, 2022

Conversation

marksweb
Copy link
Member

@marksweb marksweb commented Jul 27, 2022

This brings compatibility for the current cms v4 setup and the changes I've introduced with;

django-cms/django-cms#7369

And I've included some basic pre-commit hooks for linters to help avoid issues at the point of github actions.

This probably wants to come in with a major version bump

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #291 (4389dce) into master (914cd32) will decrease coverage by 2.26%.
The diff coverage is 50.00%.

❗ Current head 4389dce differs from pull request most recent head 532e99f. Consider uploading reports for the commit 532e99f to get more accurate results

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   86.39%   84.12%   -2.27%     
==========================================
  Files          23       23              
  Lines         801      838      +37     
  Branches      118      117       -1     
==========================================
+ Hits          692      705      +13     
- Misses         82      107      +25     
+ Partials       27       26       -1     
Impacted Files Coverage Δ
djangocms_versioning/monkeypatch/page.py 61.11% <45.83%> (-10.69%) ⬇️
djangocms_versioning/monkeypatch/extensions.py 57.35% <53.33%> (-10.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marksweb
Copy link
Member Author

That check failure can't be avoided. The extra code is going to make the coverage drop, but I guess it's a temporary change.

@fsbraun fsbraun merged commit 8a29e09 into django-cms:master Nov 30, 2022
marksweb added a commit to marksweb/djangocms-versioning that referenced this pull request Dec 7, 2022
marksweb added a commit that referenced this pull request Dec 7, 2022
* fix: Additional change missed in #291

* fix: import order for isort

* fix: import order for isort
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants