-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Compat with cms page content extension changes #291
Conversation
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
- Coverage 86.39% 84.12% -2.27%
==========================================
Files 23 23
Lines 801 838 +37
Branches 118 117 -1
==========================================
+ Hits 692 705 +13
- Misses 82 107 +25
+ Partials 27 26 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
That check failure can't be avoided. The extra code is going to make the coverage drop, but I guess it's a temporary change. |
This brings compatibility for the current cms v4 setup and the changes I've introduced with;
django-cms/django-cms#7369
And I've included some basic pre-commit hooks for linters to help avoid issues at the point of github actions.
This probably wants to come in with a major version bump