Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Django 4.0 to test matrix. #1072

Merged

Conversation

carltongibson
Copy link
Contributor

No description provided.

@carltongibson
Copy link
Contributor Author

Hey @diox. 👋

There's these two compressor.tests.test_offline.OfflineCompressTestCaseWithLazyStringAlikeUrls which started failing across the board a few months ago — not quite sure what's going on there 🤔 — but everything else is green for Django 4.0a1.

@carltongibson
Copy link
Contributor Author

OK, I don't really understand these failures yet...

There are two failures across the board there — every version, not just 4.0 — which are a bit mysterious — there's no obvious cause, and the tests are a bit hard to decipher — I'm thinking that there much have been a change in a dependency ≈4 months ago but current status is 🤔

(I haven't worked out yet how to debug the writen manifest...)

@diox
Copy link
Member

diox commented Sep 22, 2021

Yeah I noticed we started getting more or less random failures after switching to GitHub actions, but I haven't had the time to investigate yet. It's possible it's a minor detail in some dependency as you suggest. I will try to take a closer look soon.

@carltongibson
Copy link
Contributor Author

I get the failures locally.

I'm not sure what the issue is yet, or how to debug it exactly. 😅

@carltongibson
Copy link
Contributor Author

@diox if your local venv passes, could you diff it exactly to a fresh one? That might show the dependency change (if that's the problem)

The old aliases are Removed in Django 4.0.
@carltongibson
Copy link
Contributor Author

OK, all green after #1079 👯

@carltongibson carltongibson merged commit b9e4769 into django-compressor:develop Nov 22, 2021
@carltongibson carltongibson deleted the django-4.0-compatibility branch November 22, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants