add cssmin extra require #314

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

No description provided.

Owner

diox commented Nov 1, 2012

Sorry for the delay in replying to the PR. I'm not sure why we should add cssmin to extra_requires, as compressor has its own copy, and AFAIK compressor never tries to use a different version. Am I missing something here ?

Ah I didn't notice that: in that case it's worth removing the bundled version and using dependencies

Owner

diox commented Nov 1, 2012

Bundling cssmin in compressor was done on purpose in 4caa91f. I'm not completely sure if the problem mentioned in the commit is still relevant, since it was more than 2 years ago, but I'll leave the decision to touch that to @jezdez since he wrote it.

Owner

jezdez commented Mar 18, 2013

No, it shouldn't use dependencies to be able to use the CSSMinFilter out of the box.

jezdez closed this Mar 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment