Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added django-sekizai support in contrib #334

Merged
merged 2 commits into from
Nov 6, 2012
Merged

Added django-sekizai support in contrib #334

merged 2 commits into from
Nov 6, 2012

Conversation

saulshanabrook
Copy link
Contributor

Added support for django-sekizai, by supplying a postproccessor to be used that uses django-compressor. The code is taken directly from this gist. django_compressor + django-sekizai also has an issue on django-sekizai

@diox
Copy link
Member

diox commented Nov 3, 2012

The travis build failed because of these pep8 failures, can you fix them please ?
compressor/contrib/sekizai.py:11:1: E302 expected 2 blank lines, found 1
compressor/contrib/sekizai.py:18:108: W292 no newline at end of file

Thanks !

@diox
Copy link
Member

diox commented Nov 6, 2012

@saulshanabrook : one last thing, since it's not your code originally, I'd like to get confirmation from @timmyomahony that he is ok with this just to be on the safe side. I'll also ask on the issue over at django-sekizai.

@timmyomahony
Copy link

Yep. Fine with me.

diox added a commit that referenced this pull request Nov 6, 2012
Added django-sekizai support in contrib
@diox diox merged commit ef898f2 into django-compressor:develop Nov 6, 2012
@diox
Copy link
Member

diox commented Nov 6, 2012

Excellent, thanks!

@aarcro
Copy link
Contributor

aarcro commented Nov 9, 2012

sekizai.py is not in the 1.2 build distributed by pypi

@diox
Copy link
Member

diox commented Nov 9, 2012

Yes, this was just merged 3 days ago, and the 1.2 release is now 3 months old. We'll make a new release eventually, but for the time being, if you really need this, use development version or copy over the file to your project/app.

@aarcro
Copy link
Contributor

aarcro commented Nov 9, 2012

Thanks for the quick response. I'm just copying for now. I don't actually know how fast things move to pypi. And I found it in the 1.2 docs on read the docs, so I was confused when it wasn't there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants