Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't continue when raising a UnicodeDecodeError #499

Closed
wants to merge 1 commit into from

Conversation

mattrobenolt
Copy link
Contributor

Don't continue executing more code, by adding a continue to start the loop over. :)

@alexcouper
Copy link
Contributor

The travis build failed for this. Could you rebase from develop? You should then get some green travis love.

@mattrobenolt
Copy link
Contributor Author

@alexcouper Done.

@mattrobenolt
Copy link
Contributor Author

All green. :)

@mattrobenolt
Copy link
Contributor Author

Bump?

@diox
Copy link
Member

diox commented May 19, 2014

Hey, sorry I had not seen this - it needs to be rebased again (can't merge it atm), and needs a test.

@diox
Copy link
Member

diox commented Jul 27, 2015

Closing per lack of reply.

@diox diox closed this Jul 27, 2015
@mattrobenolt
Copy link
Contributor Author

@diox This is still a bug fwiw, and the patch is super simple. So not sure why this was closed.

@diox
Copy link
Member

diox commented Jul 31, 2015

It was closed because there had not been a reply in over a year, and it had no tests and wasn't applying to latest develop branch. I'll gladly merge it if those 2 issues are fixed!

@mattrobenolt
Copy link
Contributor Author

I can happily apply to the develop branch, but not sure how to test this since I'm not intimate with the code base. The logic is trivial and this was obviously a typo when originally written since every other except statement has a continue which ends up resulting in a fatal NameError on template not existing.

We see this in our CI builds all the time.

@mattrobenolt
Copy link
Contributor Author

@diox I just rebased and pushed to my branch, but the PR didn't update now since it's closed, but the commit is mattrobenolt/django-compressor@31454b0

@diox
Copy link
Member

diox commented Jul 31, 2015

Ok, I can't re-open the PR, so can you submit a new PR with that please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants