Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2022.1: Circular dependency with django-crispy-forms #3

Closed
dvzrv opened this issue Apr 13, 2023 · 1 comment
Closed

2022.1: Circular dependency with django-crispy-forms #3

dvzrv opened this issue Apr 13, 2023 · 1 comment

Comments

@dvzrv
Copy link

dvzrv commented Apr 13, 2023

Hi! Similar to what is discussed in django-crispy-forms/crispy-bootstrap4#7 I think that this project should also not require django or django-crispy-forms, as that creates a dependency loop which is particularly bad for bootstrap scenarioes.

Both dependencies are only required during testing. The django-crispy-forms project on the other hand should require crispy-bootstrap3 and crispy-bootstrap4.
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Apr 13, 2023
@dvzrv
upgpkg: python-crispy-bootstrap3 2022.1-2: Rebuild to prevent circula…
b6b2170 
…r dependency.

Prevent circular dependency: django-crispy-forms/crispy-bootstrap3#3

git-svn-id: file:///srv/repos/svn-community/svn@1445807 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Apr 13, 2023
@dvzrv
upgpkg: python-crispy-bootstrap3 2022.1-2: Rebuild to prevent circula…
772acc2 
…r dependency.

Prevent circular dependency: django-crispy-forms/crispy-bootstrap3#3

git-svn-id: file:///srv/repos/svn-community/svn@1445807 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@dvzrv dvzrv mentioned this issue Apr 13, 2023
Open
@smithdc1
Copy link
Member

smithdc1 commented May 4, 2023

As per the linked issue ill close this for now. Happy to re-open if someone can help me understand the issue. Or even better open a PR with a proposed fix and tests.

@smithdc1 smithdc1 closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dvzrv @smithdc1