Removed empty class attribute if field class is None (#1208)

django-crispy-forms · Jan 22, 2022 · e84b43f · e84b43f
1 parent 50e83e8
commit e84b43f
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/crispy_forms/templates/bootstrap4/field.html b/crispy_forms/templates/bootstrap4/field.html
@@ -47,7 +47,7 @@
             {% elif field|is_file and use_custom_control  %}
                 {% include 'bootstrap4/layout/field_file.html' %}
             {% else %}
-                <div class="{{ field_class }}">
+                <div{% if field_class %} class="{{ field_class }}"{% endif %}>
                     {% if field|is_select and use_custom_control %}
                         {% if field.errors %}
                             {% crispy_field field 'class' 'custom-select is-invalid' %}

diff --git a/crispy_forms/tests/results/bootstrap4/test_layout/test_file_field_clearable.html b/crispy_forms/tests/results/bootstrap4/test_layout/test_file_field_clearable.html
@@ -1,6 +1,6 @@
 <form method="post" enctype="multipart/form-data">
     <div id="div_id_clearable_file" class="form-group"> <label for="id_clearable_file" class=""> Clearable file </label>
-        <div class=""> Currently: 
+        <div>Currently:
             <a href="something">something</a>
             <input type="checkbox" name="clearable_file-clear" id="clearable_file-clear_id">
             <label for="clearable_file-clear_id">Clear</label>

diff --git a/crispy_forms/tests/results/bootstrap4/test_layout/test_file_field_default.html b/crispy_forms/tests/results/bootstrap4/test_layout/test_file_field_default.html
@@ -3,7 +3,7 @@
         <label for="id_file_field" class=" requiredField"> File field
             <span class="asteriskField">*</span>
         </label>
-        <div class=""> 
+        <div> 
             <input type="file" name="file_field" class="fileinput fileUpload form-control-file" required id="id_file_field"> 
         </div>
     </div>

diff --git a/crispy_forms/tests/results/bootstrap4/test_layout/test_form_control_size.html b/crispy_forms/tests/results/bootstrap4/test_layout/test_form_control_size.html
@@ -1,7 +1,7 @@
 <form method="post">
     <div id="div_id_first_name" class="form-group"> <label for="id_first_name" class=" requiredField"> first name<span
                 class="asteriskField">*</span> </label>
-        <div class=""> <input type="text" name="first_name" maxlength="5"
+        <div> <input type="text" name="first_name" maxlength="5"
                 class="form-control-lg textinput textInput inputtext form-control" required id="id_first_name"> </div>
     </div>
 </form>
diff --git a/...y_forms/tests/results/bootstrap4/test_layout/test_use_custom_control_in_select_false.html b/...y_forms/tests/results/bootstrap4/test_layout/test_use_custom_control_in_select_false.html
@@ -1,7 +1,7 @@
 <form method="post">
     <div class="form-group" id="div_id_select"><label class=" requiredField" for="id_select">Select<span
                 class="asteriskField">*</span></label>
-        <div class=""><select class="form-control select" id="id_select" name="select">
+        <div><select class="form-control select" id="id_select" name="select">
                 <option selected value="1">Option one</option>
                 <option value="2">Option two</option>
                 <option value="3">Option three</option>

diff --git a/...py_forms/tests/results/bootstrap4/test_layout/test_use_custom_control_in_select_true.html b/...py_forms/tests/results/bootstrap4/test_layout/test_use_custom_control_in_select_true.html
@@ -1,7 +1,7 @@
 <form method="post">
     <div class="form-group" id="div_id_select"><label class=" requiredField" for="id_select">Select<span
                 class="asteriskField">*</span></label>
-        <div class=""><select class="custom-select select" id="id_select" name="select">
+        <div><select class="custom-select select" id="id_select" name="select">
                 <option selected value="1">Option one</option>
                 <option value="2">Option two</option>
                 <option value="3">Option three</option>