New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalise (and Release) Bootstrap 4 Support #732
Comments
Sorry for my silence over the last couple months, I haven't been spending as much time as I'd like on open source work. I've updated crispy-test-project to use the beta, and it'd be great to flesh that out to cover all the issues people have mentioned. I'm gonna try make my way through some of the issues to see if they're still a problem. |
@zoidbergwill: First, no stress! OSS is a labour of love and often other things take priority. Anyone who doesn't understand that needs to reassess. ❤️ Second: Great! It's time for a new version of CF and if we can get BS4 compat finalised (bar the inevitable edge-cases) that would be a great addition. |
File inputs look pretty bad, but I don't know if that's a regression: They should look more like: Ours:
What it should be closer to:
|
Should we make separate issues under a milestone? |
@zoidbergwill Up to you: I'd be happy just to go straight to PRs with |
@zoidbergwill If you want to create fresh tickets (on the milestone) with the "Help Wanted" flag, we may get some input...? 🙂 — It would lighten the load. |
Sounds like a great idea. 👍 |
Currently for select input I'm seeing the default browser select rather than the bootstrap 4 .custom-select. The custom-select looks a lot more consistent across browsers so would be a better default but subject to opinion. If we go with the default way it would be good to have an easy way to override. I presume currently we would need to override the field template and create a custom version with a condition for {% if field|is_select%}? |
@yunti progress is a bit stalled at the moment. If you want to contribute to get BS4 support finalised that would be very welcome! |
I'm pretty sure we want the bootstrap select. That sounds like a regression. We only have an example multiselect in the crispy test project but it looks right |
I've been on holiday, but I'm back now. 👋 |
Currently errors don't appear to be working with bs4 beta 2 (or beta) but they do work with alpha 6. This example form: Generates this output, which uses bs4 beta 2 and shows missing error: Same output but with bs4 alpha 6 which has error displayed: update: its a bs4 bug twbs/bootstrap#23454 |
I'm not sure what exactly we need to document other than mentioning we support bootstrap 4 in more places, and that adding |
It looks like https://getbootstrap.com/docs/4.0/components/input-group/ |
I've made a PR: #771 I will test it in the morning properly though, and test it on crispy-test-project. |
Wow that was fast, glancing at the PR there may be some other details to getting those input boxes working as in the alpha releases. Such as the prepend/append |
Whoops, crispy-test-project was not using Bootstrap's stable release. Should be all happy now. |
Version 1.7.1 is available on PyPI now. |
As of 10 Aug 2017 Bootstrap 4 has moved from "Alpha" to "Beta".
This should bring the stability we've been missing:
I'm not using Bootstrap myself currently — so I need help with this!
I'm going to close all other bootstrap 4 issues and will take PRs
Ref #732
helping to bring the Bootstrap 4 support up to scratch.I'm planning a new release of Crispy Forms in the Autumn — before Django 2.0. If we get good input here I will bring that forward.
Thanks for the input everyone!
The text was updated successfully, but these errors were encountered: