New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for new Bootstrap4 alpha5 markup #660
Conversation
…label renamed to .col-form-label
…* renamed to .offset-*-*
…feedback classes markup
…o plus Multiple/Inline markup
…ow for non-inline forms used together with .form-group
Current coverage is 95.28% (diff: 93.47%)@@ dev #660 diff @@
==========================================
Files 24 24
Lines 2557 2588 +31
Methods 0 0
Messages 0 0
Branches 227 236 +9
==========================================
+ Hits 2436 2466 +30
Misses 74 74
- Partials 47 48 +1
|
I do not feel confident of this conditional check that I needed to add to few templates:
Thing is - for inline forms we need just
|
I will add some more markup updates in nearest time, do not accept PR yet. |
@darklow Thanks for this PR. I'll take a look at it this week. |
alphha6 is released http://blog.getbootstrap.com/2017/01/06/bootstrap-4-alpha-6/ next is beta1 could you update the pr with that? |
@darklow Any chance you could update this to latest |
Also, can you look at #676? — it's only a one liner so could easily be handled here. (Maybe it already is?) Thanks. |
I think we should wait BS4 final, it just too much refactoring on each new alpha. In the meanwhile feel free to copy edited templates from this PR to your own template directory and adjust if needed. |
Definitely a bunch of work to keep up with bootstrap v4 alpha/beta. And now there are conflicts. Hopefully will get to take a look at this properly in the next month or two. |
See #732: I've asked for help finalising Bootstrap 4 support, and we'll do a new release in the autumn before Django 2.0, or sooner if we get lots of input. BS4 is now "Beta" and should be stable enough. If this PR can be updated for that we'd be glad to have it! Ta! |
I've put these changes into my PR: #735 |
I haven't checked 100% all bootstrap markup yet, but 4x main changes I mentioned in my issue #658 post are ready. Let's me know what you think. We can also discuss checkbox double label issue before closing PR.