Remove bs3 styles from crispy_forms_field #1003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is another step towards decoupling crispy-forms-core from template packs.
This removes the bs3 styles which are currently being added in
crispy_forms_field.py
.Interestingly, and at least from what I can see in the docs,
form-control-danger
is not the right way of adding errors in bs3. 'has-error' is the solution and that's already built into the templates. This made it much easier to put the remaining logic into the templates. I suspect the bs4 templates will not be quite so easy.Here are before/after images (no change hopefully) 馃
Before:
After: