Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #938 -- Avoid attributes being duplicated #1194

Merged
merged 2 commits into from Nov 1, 2021

Conversation

smithdc1
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #1194 (6c5da19) into main (be31a5d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
- Coverage   97.30%   97.30%   -0.01%     
==========================================
  Files          23       23              
  Lines        2936     2934       -2     
  Branches      240      240              
==========================================
- Hits         2857     2855       -2     
  Misses         39       39              
  Partials       40       40              
Flag Coverage Δ
unittests 97.30% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crispy_forms/tests/test_form_helper.py 99.48% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be31a5d...6c5da19. Read the comment docs.

@smithdc1 smithdc1 changed the title Improved test_bootstrap_form_show_errors_bs3 Refs #938 -- Avoid attributes being duplicated Nov 1, 2021
Prior to this patch attrs is added to the widget each time the form is rendered. This could lead to multiple `form-control` css classes being rendered.
@smithdc1 smithdc1 merged commit 2246532 into django-crispy-forms:main Nov 1, 2021
@smithdc1 smithdc1 deleted the tests branch November 1, 2021 17:40
@smithdc1 smithdc1 added this to the Next Release milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants