Make Bootstrap StrictButton use get_template_name() from TemplateNameMixin #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomedelliott Could you rebase this please? Ta! |
tomedelliott
force-pushed
the
strict-button-template
branch
from
75134fd
to
7dc87e5
Compare
Current coverage is 95.19% (diff: 100%)@@ dev #645 diff @@
==========================================
Files 24 24
Lines 2562 2562
Methods 0 0
Messages 0 0
Branches 226 226
==========================================
Hits 2439 2439
Misses 76 76
Partials 47 47
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the bootstrap StrictButton ignores any overiding template you set in the helper.
Making it use get_template_name from Layout.TemplateNameMixin will fix this.